[skip changelog] Fix core search tests #1049
Merged
+46
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
scerza/fix-test-core-search
branch
2 times, most recently
from
b9c6b9c to
3e07fbe
Compare
per1234
reviewed
Oct 29, 2020
test/test_core.py
Outdated
| assert ["Updating", "index:", "package_index.json", "downloaded"] in lines | ||
| assert ["Updating", "index:", "package_index.json.sig", "downloaded"] in lines | ||
| assert ["Retrokits-RK002:arm", "1.0.5", "RK002"] in lines | ||
| assert ["Retrokits-RK002:arm", "1.0.6", "RK002"] in lines | ||
| header_index = lines.index(["ID", "Version", "Name"]) | ||
| assert 2 == len(lines[header_index + 1 :]) |
There was a problem hiding this comment.
Suggested change
| assert 2 == len(lines[header_index + 1 :]) | |
| assert 2 == len(lines[(header_index + 1):]) |
What do you think about doing this instead, and then leaving the E203 flake8 check intact? It seems easier to understand to me
There was a problem hiding this comment.
That wouldn't work, black would format it as lines[(header_index + 1) :] so flake8 complains anyway.
silvanocerza
force-pushed
the
scerza/fix-test-core-search
branch
from
3e07fbe to
c8895d2
Compare
cmaglie
approved these changes
Oct 30, 2020
kittaakos
reviewed
Oct 30, 2020
| lines = [l.strip().split() for l in result.stdout.strip().splitlines()] | ||
| assert ["Updating", "index:", "package_index.json", "downloaded"] in lines | ||
| assert ["Updating", "index:", "package_index.json.sig", "downloaded"] in lines | ||
| assert ["Package:x86", "1.2.3", "Platform"] in lines | ||
| assert 1 == len(lines[header_index + 1 :]) # noqa: E203 |
There was a problem hiding this comment.
Please document what # noqa: E203 does. At least in the commit message. Thanks!
silvanocerza
force-pushed
the
scerza/fix-test-core-search
branch
from
c8895d2 to
8408ef1
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
A small fix in the integration tests.
Tests might fail some times if indexes update is slower than usual.
Tests should not fail anymore if indexes update is slow.
No.
None.
See how to contribute